(feat) O3-4201: Enhance Number Question Labels Display Unit and Range (Min/Max) from Concept #454
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…(min-max) to label and min/max to form
|
@samuelmale @ibacher please let me know if you had other approaches in mind for this or issues
|
samuelmale
reviewed
Jan 6, 2025
…l, add test concept with units and range
samuelmale
reviewed
Feb 26, 2025
ibacher
requested changes
Feb 26, 2025
…ber-Question-Labels-Display-Unit-and-Range-(Min/Max)-from-Concept
…abel i18n, unit/range test cases
D-matz
commented
Mar 23, 2025
There was a problem hiding this comment.
not really sure about jest.mock('react-i18next', () => ({...
it seemed needed for the new i18n label t('{{fieldDescription}} {{unitsAndRange}}'... but I'm not sure if that's correct
ibacher
requested changes
Mar 25, 2025
…nly min test, cleaner hi/low from matchingConcept
samuelmale
reviewed
May 19, 2025
There was a problem hiding this comment.
@D-matz can you resolve the lint issues and merge conflicts and we have this merged in?
|
@samuelmale by the way, I had to add i18n usetranslation to unspecified.test.tsx and form-engine.test.tsx which I am not sure about, for those tests to pass. Also note I have 9 failing tests on yarn test on both this branch and main. So please let me know if I'm doing something wrong with these. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add (unit) (min-max) to label, validate input against concept min/max
https://openmrs.atlassian.net/browse/O3-4201
Related: https://openmrs.atlassian.net/browse/O3-4122
4122 also suggests a warning for values within the absolute range but outside normal or critical range. Looking for suggestions on how to implement that, and how to add a test case for a concept with units and min/max
Requirements
Summary
Screenshots
Related Issue
Other